[PATCH] D155573: [Clang] Fix the location of default init expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cfcde31a48: [Clang] Fix the location of default init expressions (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D155573?vs=541473&id=541853#toc Repository: rG LLVM Github

[PATCH] D155573: [Clang] Fix the location of default init expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} cor3ntin wro

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} tbaeder wrote: > aaron.ballman wrote: > > cor3ntin wrote: > > > aaron.ballman wrote: > > > > Shouldn't th

[PATCH] D155573: [Clang] Fix the location of default init expressions

tbaeder added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > Shouldn't this test fail because `i

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin updated this revision to Diff 541473. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155573/new/ https://reviews.llvm.org/D155573 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D155573: [Clang] Fix the location of default init expressions

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} cor3ntin wrote: > aaron.ballman wrote: > > Shouldn't this test fail because `i != j`? > > > > Can y

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} aaron.ballman wrote: > Shouldn't this test fail because `i != j`? > > Can you add a test that demonstrat

[PATCH] D155573: [Clang] Fix the location of default init expressions

aaron.ballman added a comment. Should this come with a release note or is it correcting functionality added for this release? Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} Shouldn'

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Default member initializations constructed from a parenthesized aggregate initialization should be constructed at the loca