[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-28 Thread Ellis Hoag via Phabricator via cfe-commits
ellis abandoned this revision. ellis added a comment. Moved to https://reviews.llvm.org/D154014 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152762/new/ https://reviews.llvm.org/D152762 ___ cfe-commits

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-15 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D152762#4421702 , @ellis wrote: > In D152762#4421630 , @phosek wrote: > >> This is unrelated to this change but related to the issue this change is >> addressing. The use of regular exp

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-14 Thread Ellis Hoag via Phabricator via cfe-commits
ellis planned changes to this revision. ellis added a comment. In D152762#4421630 , @phosek wrote: > This is unrelated to this change but related to the issue this change is > addressing. The use of regular expressions for special case list with the > s

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-14 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. This is unrelated to this change but related to the issue this change is addressing. The use of regular expressions for special case list with the special handling of `*` is error-prone, I've seen many people having issues it. Furthermore, regular expression for matching

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. For this patch, the best test is actually `llvm/unittests/Support/SpecialCaseListTest.cpp`. `clang/test/CodeGen/profile-filter-new.c` is a bit loosely connected to the gist of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > "The meaning of * in regular expression for entity names is different - it is > treated as in shell wildcarding." Right. See `SpecialCaseList.cpp` > I've removed fun:MyFooBar since it mad

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

2023-06-12 Thread Ellis Hoag via Phabricator via cfe-commits
ellis created this revision. Herald added a project: All. ellis retitled this revision from "[clang][docs] Update Sanitizer docs and test" to "[clang][docs] Update SanitizerSpecialCaseList docs". ellis edited the summary of this revision. ellis added reviewers: vlad.tsyrklevich, MaskRay. ellis pub