phosek added a comment. This is unrelated to this change but related to the issue this change is addressing. The use of regular expressions for special case list with the special handling of `*` is error-prone, I've seen many people having issues it. Furthermore, regular expression for matching file names requires excessive escaping (see for example https://fuchsia-review.git.corp.google.com/c/fuchsia/+/763162) and most patterns used for function names only utilize `*`, not requiring the full strength of regular expression. I think we should consider replacing regular expressions with glob patterns. These are already implemented in https://github.com/llvm/llvm-project/blob/3391bdc255f1a75c59d71c7305959e84d8d5f468/llvm/include/llvm/Support/GlobPattern.h so the implementation should be straightforward, but it's going to be a breaking change. I don't know how widespread the use of special case lists is and whether that's going to be an issue?
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152762/new/ https://reviews.llvm.org/D152762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
