This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0d8d71817119: [OpenMP] Change clang emitTargetDataCalls to
use OMPIRBuilder (authored by TIFitis).
Repository:
rG LLVM Github Monorepo
CHANGES SI
TIFitis updated this revision to Diff 536216.
TIFitis added a comment.
Rebased to fix build error.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/te
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
Let's move on. I described what this should look like, just for the record.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399
+DeviceID = CGF.Builder.getInt64
TIFitis added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10395-10399
+if (CGF.ConstantFoldsToSimpleInteger(IfCond, CondConstant)) {
+ IfCondVal = CGF.Builder.getInt1(CondConstant);
+} else {
+ IfCondVal = CGF.EvaluateExprAsBool(IfCond);
+
TIFitis updated this revision to Diff 535455.
TIFitis marked an inline comment as done.
TIFitis added a comment.
Addressed reviewer comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/
arsenm added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10395-10399
+if (CGF.ConstantFoldsToSimpleInteger(IfCond, CondConstant)) {
+ IfCondVal = CGF.Builder.getInt1(CondConstant);
+} else {
+ IfCondVal = CGF.EvaluateExprAsBool(IfCond);
+
TIFitis added a comment.
Gentle ping :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
TIFitis updated this revision to Diff 533619.
TIFitis added a comment.
Moved device clause emition after if clause.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/lib/CodeGen/CGOpenMPRunti
TIFitis added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399
+DeviceID = CGF.Builder.getInt64(OMP_DEVICEID_UNDEF);
+ }
jdoerfert wrote:
> Move this behind the if generation and guard the emit scalar with a
> conditional, all is o
jdoerfert added inline comments.
Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356
// Region 00
+// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64
+// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}},
// CK2: br i1 %{{[^,]+}}, label %[[IFTHEN:[^,]+]], lab
jdoerfert added a comment.
This looks pretty good. The device vs if clause thing should be fixed while we
are here.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399
+DeviceID = CGF.Builder.getInt64(OMP_DEVICEID_UNDEF);
+ }
Move this behind the if
TIFitis updated this revision to Diff 531761.
TIFitis added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/target_dat
TIFitis updated this revision to Diff 530865.
TIFitis added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/target_dat
TIFitis updated this revision to Diff 530533.
TIFitis marked an inline comment as done.
TIFitis added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/lib/CodeGen/CGOpenMP
TIFitis marked an inline comment as done.
TIFitis added inline comments.
Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356
// Region 00
+// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64
+// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}},
// CK2: br i1
jsjodin added inline comments.
Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356
// Region 00
+// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64
+// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}},
// CK2: br i1 %{{[^,]+}}, label %[[IFTHEN:[^,]+]], label
TIFitis updated this revision to Diff 527931.
TIFitis marked 2 inline comments as done.
TIFitis added a comment.
Addressed reviewer comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang
jplehr added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10412
+ CGF.Builder.GetInsertPoint());
+ llvm::OpenMPIRBuilder::LocationDescription ompLoc(CodeGenIP);
capitalize here?
Comment at: clan
TIFitis marked 2 inline comments as not done.
TIFitis added a comment.
Ping for reviews :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
___
cfe-commits maili
TIFitis updated this revision to Diff 524310.
TIFitis added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/target_dat
TIFitis added inline comments.
Comment at: clang/test/OpenMP/target_data_codegen.cpp:67-68
- // CK1-DAG: call void @__tgt_target_data_end_mapper(ptr @{{.+}}, i64
[[DEV:%[^,]+]], i32 1, ptr [[GEPBP:%.+]], ptr [[GEPP:%.+]], ptr [[SIZE00]], ptr
[[MTYPE00]], ptr null, ptr null)
-
TIFitis created this revision.
TIFitis added reviewers: jsjodin, dpalermo, kiranktp, jdoerfert.
Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl.
Herald added a project: All.
TIFitis requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, jplehr, sste
22 matches
Mail list logo
