TIFitis added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10395-10399
+ if (CGF.ConstantFoldsToSimpleInteger(IfCond, CondConstant)) {
+ IfCondVal = CGF.Builder.getInt1(CondConstant);
+ } else {
+ IfCondVal = CGF.EvaluateExprAsBool(IfCond);
+ }
----------------
arsenm wrote:
> Why do you need to do this? I would expect EvaluateExprAsBool to handle the
> constant case for you
`CGOpenMPRuntime::emitIfClause` has the check for
`ConstantFoldsToSimpleInteger` so I added it here.
Removing it didn't break any test so I've updated it,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150860/new/
https://reviews.llvm.org/D150860
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
