[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. Just an update on this, it works well but some of the cases are not tolerant to comments, I'm working my way through those issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515372. MyDeveloperDay added a comment. Handle the case string Foo { set;get; } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. There is another case I need to cover Style.BraceWrapping.AfterCSharpProperty = false; Style.AllowShortCSharpPropertiesOnASingleLine = false; Style.AlwaysBreakBetweenShortCSharpProperties = false; Style.Brace

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515298. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Address review comment, add convenience functions to simplify conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:21 #include "llvm/Support/Debug.h" +#include What is this? Comment at: clang/lib/Format/TokenAnnotator.cpp:5023-5026 + // string Foo + // {

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. In my C# project, these settings give me just what we tend to use. BreakBeforeBraces: Custom BraceWrapping: AfterFunction: true AfterCSharpProperty: true AllowShortCSharpPropertiesOnASingleLine: false AlwaysBreakBetweenShortCSharpProperties: false

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515068. MyDeveloperDay added a comment. Sorry had a clang-format reflow comments moment, revert the unrelated comment changes simplify the if's a little CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D1484

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515060. MyDeveloperDay added a comment. Adds additional options to give us much greater control over how we format C# properties especially auto properties (Submitting this for safe keeping, I need to try and minimize the if expression, I'm sure it c

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. There is more to this than meets the eye.. what we have so far, from existing `AfterFunction` use and the propsed here `AfterCSharpProperty` is... public Foo {<--- controlled by **AfterFunction **(rightly or wrongly) get {

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added a comment. In D148467#4277960 , @MyDeveloperDay wrote: >>> public Foo { >>> set; >>> get; >>> } >> >> At least from my experience, the getter is specified before the setter, >> though I'm unsure how important thi

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

StrangeRanger added a comment. In D148467#4277960 , @MyDeveloperDay wrote: > I'm trying to decide if I put that option in this change or in a separate > change (thoughts @HazardyKnusperkeks, @owenpan ) I'm not too privy to your workflow, but if by "in

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514684. MyDeveloperDay added a comment. upload the correct patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514682. MyDeveloperDay added a comment. add init support and fix indentation issue when only one property is defined but the is an auto-property CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 File

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. >> public Foo { >> set; >> get; >> } > > At least from my experience, the getter is specified before the setter, > though I'm unsure how important this is in your eyes. Lets hold off the idea of swapping `set;get` around from this patch, but this

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

StrangeRanger added a comment. In D148467#4272231 , @MyDeveloperDay wrote: > for default `set;get` or `get;set` for when `AfterCSharpProperty` is true, > > public Foo { > set; > get; > } At least from my experience, the getter is specifi

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. need to handle `init;` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514586. MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added a comment. Address review comments, still would like to solve the indenting issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.or

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > MyDeveloperDay wrote: > > > HazardyKnusperkeks wrote: > > > > Please s

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > HazardyKnusperkeks wrote: > > > Please sort. :) > > Are we sure

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Please sort. :) > Are we sure we want THIS to be alphabetic

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5007-5010 + (Left.is(tok::semi) && Left.Previous && +Left.Previous->is(Keywords.kw_get) && Right.is(tok::r_brace)) || + (Left.is(tok::semi) && Left.Previous && +Left.Previou

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; HazardyKnusperkeks wrote: > Please sort. :) Are we sure we want THIS to be alphabetic, as this changes the initialize

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added a comment. In D148467#4272173 , @MyDeveloperDay wrote: > I'm not convinced `AfterCSharpProperty` is a good name, open for suggestions I've not enough domain knowledge to name it. Comment at: clang/include/cl

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514030. MyDeveloperDay added a comment. re clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514029. MyDeveloperDay added a comment. for default `set;get` or `get;set` for when `AfterCSharpProperty` is true, public Foo { set; get; } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D1

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. I'm not convinced `AfterCSharpProperty` is a good name, open for suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 ___ cfe-commits mailing list cfe-commits@

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:1633 + "{\n" + "string Foo { set; get }\n" + "}\n", Hmm.. maybe this should be ``` string Foo { set;get } ``` CHAN

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cp

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, HazardyKnusperkeks, rymiel. MyDeveloperDay added a project: clang-format. Herald added projects: All, clang. MyDeveloperDay requested review of this revision. This change allows always breaking before braces on C# sette