[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520025. barannikov88 added a comment. Move interface comments to the header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520015. barannikov88 added a comment. - Rebase on top of the stack - Fix a header comment - Split some virtual functions to avoid extra includes in header files - Forward declare a few classes and add necessary includes (IWYU, header files only) Reposi

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 518264. barannikov88 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Update references to modified files in non-code files - Add LLVM_LIBRARY_VISIBILITY to classes in header files Repository: rG LLVM Github Mo

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Thank you all for taking a look! In D148094#4296346 , @aaron.ballman wrote: > I did not verify that the refactoring didn't change functionality, but > spot-checking did not find any differences. In D148094#4302879

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 518199. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfoIm

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

efriedma added a comment. Restructuring seems overall reasonable. (I'm assuming there isn't actually any changed code, just moving code around.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 _

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

myhsu added a comment. In D148094#4284316 , @barannikov88 wrote: > ping > Does the approach look right? This definitely improves the readability and potentially the compilation time. > Would it be better to put everything into cpp files and only expose

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

asb added a comment. +1 on this refactoring being a good idea. The RISC-V changes seem fine to me (haven't done a detailed line by line review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 __

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

MaskRay added a comment. This refactoring looks reasonable to me as well. In `clang/lib/Driver`, we have D30372 that splits some huge files into target-specific files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

aaron.ballman added a reviewer: efriedma. aaron.ballman added a comment. I think this is a reasonable refactoring, but I'm hoping the CodeGen code owners can chime in with their thoughts as well given how large the changes are in their area. (I did not verify that the refactoring didn't change

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. ping Does the approach look right? Would it be better to put everything into cpp files and only expose a factory method e.g. createMyTargetCodeGenInfo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https:/

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 created this revision. Herald added subscribers: luke, nlopes, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, mgrang, edwa