myhsu added a comment. In D148094#4284316 <https://reviews.llvm.org/D148094#4284316>, @barannikov88 wrote:
> ping > Does the approach look right? This definitely improves the readability and potentially the compilation time. > Would it be better to put everything into cpp files and only expose a factory > method e.g. createMyTargetCodeGenInfo? I'm fine with either approach. Also, the 68k part looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
