[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 ___

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 added a comment. In D148092#4317438 , @efriedma wrote: > Is there some alternative way we can write this? Even if each of the > overrides is only technically used in one place, it's a repeating pattern, > and writing the casts inline makes

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 updated this revision to Diff 519723. barannikov88 added a comment. Add a templated overload to help derived classes avoid explicit casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma added a comment. Is there some alternative way we can write this? Even if each of the overrides is only technically used in one place, it's a repeating pattern, and writing the casts inline makes it really hard to read. (Maybe the helpers can be somewhere else?) Repository: rG LL

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 updated this revision to Diff 518191. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 added a comment. In D148092#4302861 , @efriedma wrote: > Is this supposed to be different from D148093 > ? Yes indeed. I've updated D148093 . Repository: rG LLVM Github

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma added a comment. Is this supposed to be different from D148093 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 ___

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 created this revision. Herald added a project: All. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane. barannikov88 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove `getABIInfo` overrides returning refere