barannikov88 added a comment.

In D148092#4317438 <https://reviews.llvm.org/D148092#4317438>, @efriedma wrote:

> Is there some alternative way we can write this?  Even if each of the 
> overrides is only technically used in one place, it's a repeating pattern, 
> and writing the casts inline makes it really hard to read.  (Maybe the 
> helpers can be somewhere else?)

Thanks for the suggestion. Does it look better now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148092/new/

https://reviews.llvm.org/D148092

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to