Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-18 Thread Yury Gribov via cfe-commits
ygribov added inline comments. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + } zaks.anna wrote:

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-18 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Fixed and committed. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + } --

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253532: [analyzer] Improve modeling of static initializers. (authored by zaks). Changed prior to commit: http://reviews.llvm.org/D14652?vs=40144&id=40582#toc Repository: rL LLVM http://reviews.llvm.

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-17 Thread Yury Gribov via cfe-commits
ygribov added inline comments. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + } zaks.anna wrote:

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-17 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + } Why are we che

[PATCH] D14652: [analyzer] Improve modeling of static initializers.

2015-11-13 Thread Yury Gribov via cfe-commits
ygribov created this revision. ygribov added reviewers: zaks.anna, dcoughlin, jordan_rose. ygribov added a subscriber: cfe-commits. Conversions between unrelated pointer types (e.g. char * and void *) involve bitcasts which were not properly modeled in case of static initializers. The patch fixe