[PATCH] D146420: Document the Clang policies on claiming support for a feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce548b6130b6: Document the Clang policies on claiming support for a feature (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. I have some minor reservations about defining feature macros on a per-target basis but at the same time, given the current coroutines on 32 bits windows situation - which has been li

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman updated this revision to Diff 508301. aaron.ballman added a comment. Fixing a typo pointed out off-list (missed an "as"). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146420/new/ https://reviews.llvm.org/D146420 Files: clang/docs/InternalsManual.rst Index: clang/docs

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146420/new/ https://reviews.llvm.org/D146420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman updated this revision to Diff 506624. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146420/new/ https://reviews.llvm.org/D146420 Files: clang/docs/InternalsMa

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilations?

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilati

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilations?

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman updated this revision to Diff 506591. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. (Note: Phab seems to be confused about the changes being at the end of the file -- it claims there's no trailing context for the p

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman marked 5 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there k

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin added inline comments. Comment at: clang/docs/InternalsManual.rst:3285 + * Are there known issues with the feature that reject valid code? + * Are there known issues that fail to reject invalid code? + * Are there known crashes, failed assertions, or miscompilations?

[PATCH] D146420: Document the Clang policies on claiming support for a feature

erichkeane added inline comments. Comment at: clang/docs/InternalsManual.rst:3276 +Some of these feature tests are standardized, like ``__has_cpp_attribute`` or +``__cpp_decltype``, while others are Clang extensions, like ``__has_builtin``. +The common theme among all the various

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, rsmith. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We do not currently have this written down anywhere, and as a result, we're sometimes inconsi