[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Making use of this in LLDB (see https://reviews.llvm.org/D145078) was a bit too finicky for my taste, so I prepared an alternative which doesn't require adding a new attribute and no LLDB changes. I *think* this is what @aprantl and @dblaikie had in mind couple of we

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

dblaikie added a comment. In D145077#4168209 , @dblaikie wrote: > In D145077#4162110 , @aprantl wrote: > >> I originally was hoping we wouldn't have to introduce a new attribute for >> this, but it looks like the

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

dblaikie added a comment. In D145077#4162110 , @aprantl wrote: > I originally was hoping we wouldn't have to introduce a new attribute for > this, but it looks like there are legitimate concerns about the alternatives, > so in that sense this looks good

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501569. Michael137 added a comment. - Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CG

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501568. Michael137 added a comment. - Add test case for multiple alias templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebug

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I originally was hoping we wouldn't have to introduce a new attribute for this, but it looks like there are legitimate concerns about the alternatives, so in that sense this looks good! Re

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Since the new attribute only gets attached to a structure definition, and the preferred_name attribute is currently only really used in a handful of places in libcxx, this practically doesn't affect debug-info size Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501544. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/C

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501540. Michael137 added a comment. - Remove redundant TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, we now emit a `DW_AT_LLVM_preferred_name` for the `[cl