eugenis closed this revision.
eugenis added a comment.
Confirmed and landed as r252385.
Thanks for the quick response!
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
eugenis added a comment.
Yes. I'm just using libc++.so as a (incomplete) test that this is actually NFC.
It did catch the extern template issue.
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.ll
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
It's not just libc++.so that could have it's ABI affected by adding/removing
these. It's any shared library build against libc++. However if we are just
moving the attribute to the proper plac
eugenis added a comment.
This is a mechanical change, and AFAIR I checked that no bits of libc++.so are
affected.
The same mechanical change in streambuf/istream/ostream (the stuff that's parts
of extern templates) breaks libc++ because of
https://llvm.org/bugs/show_bug.cgi?id=25427, that's wh
EricWF added a comment.
Is this a mechanical change, or do you remove/add some attributes in this patch?
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
EricWF added a comment.
Thank you so much! I was procrastination taking this on.
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis created this revision.
eugenis added reviewers: EricWF, mclow.lists.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
This change moves visibility attributes from out-of-class method definitions to
in-class declaration.
This is needed for a
