[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added a comment. Updated patch limited to changing the feature test macro value would match Varna meeting outcome (changes to allow macro to be `0` accepted as DR). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143670/new/ h

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

erichkeane added a comment. In D143670#4142351 , @aaron.ballman wrote: > In D143670#4133677 , @rsmith wrote: > >> Until or unless a C++ DR permits us to define >> `__has_cpp_attribute(carries_dependency)` to any

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D143670#4133677 , @rsmith wrote: > Until or unless a C++ DR permits us to define > `__has_cpp_attribute(carries_dependency)` to any value other than `200809L`, > we have a

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

rsmith added a comment. Until or unless a C++ DR permits us to define `__has_cpp_attribute(carries_dependency)` to any value other than `200809L`, we have a conformance requirement to macro-expand this to that value. CWG2695 only adds a note, so it changes nothing in this regard. Similarly, we

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:51 // FIXME(201806L) CHECK: assert: 0 -// CHECK: carries_dependency: 200809L +// CHECK: carries_dependency: 0 // CHECK: deprecated: 201309L aaron.ballman wrote:

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D143670#4116858 , @erichkeane wrote: > The guidance from EWG this week and in the past was that we are always > required to 'parse and diagnose appertainment' of standard

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added a comment. I think it may be an option to use the `gnu++*` modes to do deliberately non-conforming things, but I believe there should be an RFC for that first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143670/new/

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:51 // FIXME(201806L) CHECK: assert: 0 -// CHECK: carries_dependency: 200809L +// CHECK: carries_dependency: 0 // CHECK:

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

tahonermann added a comment. > The guidance from EWG this week and in the past was that we are always > required to 'parse and diagnose appertainment' of standard attributes, but > not to enable __has_cpp_attribute unless we actually 'do' something with it. > I intend/suggest we add a condition

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. The guidance from EWG this week and in the past was that we are always required to 'parse and diagnose appertainment' of standard attributes, but not to enable __has_cpp_attr

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

philnik added a comment. In D143670#4116118 , @cor3ntin wrote: > Thanks for doing this Aaron. > Did you look in libc++ if they used it anywhere? (I assume they don't) I'm not aware of any uses, and I would be quite surprised if it was used anywhere give

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks for doing this Aaron. Did you look in libc++ if they used it anywhere? (I assume they don't) Comment at: clang/docs/ReleaseNotes.rst:131 +- Clang no longer claims

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, erichkeane, rsmith, hubert.reinterpretcast. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The `[[carries_depe