This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9271c5da434b: [Clang] Adjust PIC handling for the AMDGPU
ToolChain (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:71
}
- bool isPICDefaultForced() const override { return false; }
+ bool isPICDefaultForced() const override { return true; }
bool SupportsProfiling() const override { return false; }
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
I don't understand how the PIC options are supposed to propagate given that
codegen seems to still use magic flags but removing a special case seems good
Comment at: clang/l
jhuber6 created this revision.
jhuber6 added reviewers: arsenm, JonChesterfield, yaxunl, t-tye, msearles.
Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, Mas
