arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
I don't understand how the PIC options are supposed to propagate given that
codegen seems to still use magic flags but removing a special case seems good
================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:71
}
- bool isPICDefaultForced() const override { return false; }
+ bool isPICDefaultForced() const override { return true; }
bool SupportsProfiling() const override { return false; }
----------------
What's the difference between isPICDefault and isPICDefaultForced?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142999/new/
https://reviews.llvm.org/D142999
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
