[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. In D142196#4077708 , @jansvoboda11 wrote: > Yes, I meant the `pp-trace` docs. Why would "we didn't find the included > file" not be a traceable event? My thinking is the following: If the preprocessor cannot find the included

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 added a comment. Yes, I meant the `pp-trace` docs. Why would "we didn't find the included file" not be a traceable event? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I checked a second time and couldn't find other API docs. I've now pushed this change for now (also to get it included in `release/16.x`), but please let me know for any follow-ups. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Hahnfeld marked an inline comment as done. Closed by commit rG01eb01c7fd7a: [clang][Lex] Add back PPCallbacks::FileNotFound (authored by Hahnfeld). Repository: rG LL

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In D142196#4074249 , @jansvoboda11 wrote: > Also I think we should mention this API in our docs, right where the removed > original used to be. Which API docs are you referring to? I'

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491522. Hahnfeld added a comment. Update comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp clang/unittests/Lex/PPCa

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 added a comment. Also I think we should mention this API in our docs, right where the removed original used to be. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 ___ cfe-commits mailin

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM with improved wording. Comment at: clang/include/clang/Lex/PPCallbacks.h:87 + /// Callback invoked whenever an inclusion directive results in a + /// file-

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491095. Hahnfeld added a comment. Add unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp clang/unittests/Lex/PPCal

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 added a comment. In D142196#4068428 , @Hahnfeld wrote: > I just checked and this "simplified" version of the callback would give us > enough information to implement all we need in ROOT (plus some, the `bool` > return value is nicer than te

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I just checked and this "simplified" version of the callback would give us enough information to implement all we need in ROOT (plus some, the `bool` return value is nicer than temporarily playing with `SuppressIncludeNotFoundError`). For an upstream test, I could impl

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld created this revision. Hahnfeld added reviewers: jansvoboda11, ahoppen. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This callback was r