jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM with improved wording.
================
Comment at: clang/include/clang/Lex/PPCallbacks.h:87
+ /// Callback invoked whenever an inclusion directive results in a
+ /// file-not-found error.
+ ///
----------------
The wording is a bit misleading due to:
```
if (SuppressIncludeNotFoundError)
return std::nullopt;
```
after invoking this callback. Reading the comment, I assume the diagnostic has
already been issued. Can we tweak this to clarify things?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142196/new/
https://reviews.llvm.org/D142196
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
