This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc7fc0abf510f: [clangd] Add script to maintain list of fast
clang-tidy checks (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES
sammccall updated this revision to Diff 477443.
sammccall added a comment.
Script reads/writes from file rather than redirecting output.
Update .inc file to show "no-op" changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138491/new/
https://rev
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/TidyFastChecks.inc:2
+// This file is generated, do not edit it directly!
+// This describes
+#ifndef FAST
can
sammccall updated this revision to Diff 477424.
sammccall marked an inline comment as done.
sammccall added a comment.
review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138491/new/
https://reviews.llvm.org/D138491
Files:
clang-tools-
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/TidyFastChecks.py:41
+def read_old_fast(path):
+text = subprocess.check_output(["cpp", "-P", "-FAST(C,T)=C", path])
+for line in text.splitlines():
--
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/TidyFastChecks.py:31
+default='clang-tools-extra/clangd/TidyFastChecks.inc')
+parser.add_argument('--file', help='clangd binary to invoke',
+default='clang/lib/Sema/Sema.cpp')
`file to u
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: abrachet, phosek, arphaman.
Herald added a reviewer: njames93.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay, ilya-bi
