[PATCH] D137851: [OPENMP]Initial support for at clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG628fdc3f57ad: [OPENMP]Initial support for at clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2168 +Actions.ActOnOpenMPErrorDirective(Clauses, StartLoc, SourceLocation(), + /*InExcontext = */ false); +break; ABataev wrote: > InExContext Sor

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475490. jyu2 added a comment. Thanks Alexey for the review. This is address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2168 +Actions.ActOnOpenMPErrorDirective(Clauses, StartLoc, SourceLocation(), + /*InExcontext = */ false); +break; InExContext ===

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added a comment. In D137851#3925661 , @jdoerfert wrote: > Drive by: Please add commit messages to non trivial changes to explaining > what's going on. Thanks. Added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D137851: [OPENMP]Initial support for at clause

jdoerfert added a comment. Drive by: Please add commit messages to non trivial changes to explaining what's going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 _

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'. ABa

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475225. jyu2 added a comment. Thanks Alexey! Address Alexey comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'.

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3302 + void ParseOpenMPClauses(OpenMPDirectiveKind DKind, + SmallVector *Clauses, + SourceLocation Loc); ABataev wrote: > `SmallVectorImp

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475177. jyu2 added a comment. Thanks Alexey! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Re

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3302 + void ParseOpenMPClauses(OpenMPDirectiveKind DKind, + SmallVector *Clauses, + SourceLocation Loc); `SmallVectorImpl &` ===

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475013. jyu2 added a comment. try fix format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 474874. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/A

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:102 .Default(OMPC_ATOMIC_DEFAULT_MEM_ORDER_unknown); + case OMPC_at: + return llvm::StringSwitch(Str) I run git-clang-format I don't see any change. I don't know where has prob

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev wrote: > Make it private Thanks. Yes. Changed Co

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 474826. jyu2 added a comment. Herald added a project: Flang. Thanks Alexey, for the review. This is addressing his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + Make it private Comment at: clang/include/clang/Parse/P

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Her