jyu2 added inline comments.
================
Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615
+ /// Sets the location of '('.
+ void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; }
+
----------------
ABataev wrote:
> Make it private
Thanks. Yes. Changed
================
Comment at: clang/include/clang/Parse/Parser.h:3296-3304
+ /// Parses clauses for directive.
+ ///
+ /// \param DKind Kind of current directive.
+ /// \param clauses for current directive.
+ /// \param start location for clauses of current directive
+ void ParseOpenMPClauses(OpenMPDirectiveKind DKind,
+ SmallVector<clang::OMPClause *, 1> *Clauses,
----------------
ABataev wrote:
> Could you make it in a separate NFC patch?
Changed.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:11034-11037
+ for (const OMPClause *CNew : Clauses) {
+ if (auto *AtCl = cast<OMPAtClause>(CNew))
+ AtC = AtCl;
+ }
----------------
ABataev wrote:
> `find_first_of`?
Thanks. Changed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137851/new/
https://reviews.llvm.org/D137851
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
