[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. In D137327#4267342 , @MyDeveloperDay wrote: > You have commit rights correct? you really need to own your change especially > if it causes a regression. Alright - I did that now. Sorry I am just used to be on the other side as m

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. In D137327#4267239 , @thieta wrote: > In D137327#4235255 , > @MyDeveloperDay wrote: > >> In D137327#4234463 , @thieta wrote: >> >>> This w

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. Herald added a reviewer: rymiel. In D137327#4235255 , @MyDeveloperDay wrote: > In D137327#4234463 , @thieta wrote: > >> This was released in LLVM 16.0.0. > > The prior behaviour was there

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. In D137327#4234463 , @thieta wrote: > This was released in LLVM 16.0.0. The prior behaviour was there before, it’s marked in GitHub as a regression, can you please revert, we’ll mark the issue to be cherry picked, then le

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. I like both @owenpan suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

owenpan added a comment. In D137327#4233551 , @thieta wrote: > In D137327#4233290 , > @MyDeveloperDay wrote: > >> because of https://github.com/llvm/llvm-project/issues/61785 should this >> really be reverted?

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

owenpan added a comment. In D137327#4234463 , @thieta wrote: > This was released in LLVM 16.0.0. I think we should revert it in 16.0.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://re

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. This was released in LLVM 16.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks added a comment. In D137327#4233652 , @MyDeveloperDay wrote: > In D137327#4233551 , @thieta wrote: > >> In D137327#4233290 , >> @MyDeveloperDay wrote:

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. In D137327#4233551 , @thieta wrote: > In D137327#4233290 , > @MyDeveloperDay wrote: > >> because of https://github.com/llvm/llvm-project/issues/61785 should this >> really be reve

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. In D137327#4233290 , @MyDeveloperDay wrote: > because of https://github.com/llvm/llvm-project/issues/61785 should this > really be reverted? is basically saying `X * Y {` must be `X *Y{` but that > obviously not the case Tri

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. because of https://github.com/llvm/llvm-project/issues/61785 should this really be reverted? is basically saying `X * Y {` must be `X *Y{` but that obviously not the case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70de684d4413: [clang-format] Handle object instansiation in if-statements (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta marked 2 inline comments as done. thieta added a comment. I have expanded testing and moved it to the place you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 __

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta updated this revision to Diff 473169. thieta added a comment. Expand and move testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:366 + CurrentToken->is(tok::identifier) && + !Next->isOneOf(tok::equal, tok::l_brace)) { Prev->setType(TT_BinaryOperator); Could you a

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch code like this: if (Class* obj{getObject()}) {