This revision was automatically updated to reflect the committed changes.
Closed by commit rG990c18937967: [clangd] Add scoped enum constants to
all-scopes-completion (authored by tom-anders).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Looks good, thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
https://reviews.llvm.org/D137104
_
tom-anders updated this revision to Diff 472578.
tom-anders marked an inline comment as done.
tom-anders added a comment.
Actually fix test...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
https://reviews.llvm.org/D137104
Files:
clan
tom-anders marked an inline comment as done.
tom-anders added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2136
+ if (llvm::isa(ND.getDeclContext()))
+return true;
nridge wrote:
> Why remove the `(InTopLevelScope(*EnumDecl) || InC
tom-anders updated this revision to Diff 472568.
tom-anders added a comment.
Update `CompletionTest.Enums`, keep scope condition in
isIndexedForCodeCompletion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
https://reviews.llvm.org/D1371
nridge added a comment.
The test added in the previous patch, `CompletionTest.Enums`, needs to be
updated to reflect this change (`Scoped::Clangd3` now appears as a completion).
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2136
+ if (llvm::isa(ND.getDeclContext()))
+
tom-anders updated this revision to Diff 472426.
tom-anders added a comment.
Rebase onto previous commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
https://reviews.llvm.org/D137104
Files:
clang-tools-extra/clangd/CodeComplete.cpp
tom-anders updated this revision to Diff 472103.
tom-anders added a comment.
Added missing hunk in CodeComplete.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
https://reviews.llvm.org/D137104
Files:
clang-tools-extra/clangd/CodeCo
tom-anders created this revision.
tom-anders added a reviewer: nridge.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
tom-anders requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
