nridge added a comment. The test added in the previous patch, `CompletionTest.Enums`, needs to be updated to reflect this change (`Scoped::Clangd3` now appears as a completion).
================ Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2136 + if (llvm::isa<clang::EnumDecl>(ND.getDeclContext())) + return true; ---------------- Why remove the `(InTopLevelScope(*EnumDecl) || InClassScope(*EnumDecl))` part? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/ https://reviews.llvm.org/D137104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits