[PATCH] D136449: [Clang] Implement P2513

cor3ntin added a comment. Thanks Aaron! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D136449: [Clang] Implement P2513

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d2772379bd: [Clang] Implement P2513 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D136449?vs=469715&id=470179#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a missing full stop in a comment. Tom's on vacation most of this week, so if he has any concerns, they can be address post-commit unless you want to wait for him

[PATCH] D136449: [Clang] Implement P2513

cor3ntin updated this revision to Diff 469715. cor3ntin edited the summary of this revision. cor3ntin added a comment. Enable the change in -fchar8_t mode as per suggestion from Aaron. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:701 +Builder.defineMacro("__cpp_char8_t", +LangOpts.CPlusPlus20 ? "202207L" : "201811L"); Builder.defineMacro("__cpp_impl_destroying_delete", "201806L"); --

[PATCH] D136449: [Clang] Implement P2513

cor3ntin added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:701 +Builder.defineMacro("__cpp_char8_t", +LangOpts.CPlusPlus20 ? "202207L" : "201811L"); Builder.defineMacro("__cpp_impl_destroying_delete", "201806L"); ---

[PATCH] D136449: [Clang] Implement P2513

cor3ntin updated this revision to Diff 469690. cor3ntin added a comment. Improve commit message, check proper integral conversions, remove ws changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 Files

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added a comment. In D136449#3875159 , @cor3ntin wrote: > In D136449#3874867 , @aaron.ballman > wrote: > >> Thanks for this! Can you add more details to the patch summary as to what >> this paper do

[PATCH] D136449: [Clang] Implement P2513

cor3ntin added a comment. In D136449#3874867 , @aaron.ballman wrote: > Thanks for this! Can you add more details to the patch summary as to what > this paper does? Paper numbers help, but don't convey a whole lot of > information at a glance if we need

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added a comment. Thanks for this! Can you add more details to the patch summary as to what this paper does? Paper numbers help, but don't convey a whole lot of information at a glance if we need to come back to this review for code archeology. Please also add a test to the correct

[PATCH] D136449: [Clang] Implement P2513

cor3ntin updated this revision to Diff 469595. cor3ntin added a comment. Remove unused diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D136449: [Clang] Implement P2513

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is applied to C++20 as a defect report. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136449 Fi