cor3ntin added inline comments.
================ Comment at: clang/lib/Frontend/InitPreprocessor.cpp:701 + Builder.defineMacro("__cpp_char8_t", + LangOpts.CPlusPlus20 ? "202207L" : "201811L"); Builder.defineMacro("__cpp_impl_destroying_delete", "201806L"); ---------------- aaron.ballman wrote: > Why do we not want to go with `202207L` regardless of language mode if this > is being applied as a DR? There is a `-fchar8_t` that is an extension before C++20 and we are not touching that. It is pre-existing that the feature test macro was defined before c++20 if that flag was set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits