[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

This revision was automatically updated to reflect the committed changes. Closed by commit rGf911598bd440: [clang][AIX] Omitting Explicit Debugger Tuning Option (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4374 + ? llvm::DebuggerKind::Default + : DebuggerTuning); probinson wrote: > Seems like you should be able to return `D

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4374 + ? llvm::DebuggerKind::Default + : DebuggerTuning); Seems like you should be able to return `DebuggerKind::Default

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/debug-options.c:121 // RUN: %clang -### -c -g %s -target powerpc-ibm-aix-xcoff 2>&1 \ -// RUN: | FileCheck -check-prefix=G_LIMITED -check-prefix=G_DBX %s +//

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 469223. qiongsiwu1 removed a project: All. qiongsiwu1 added a comment. Herald added a project: All. Adding two test cases to match `G_NOTUNING`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ http

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM except one minor in the testcase. Thanks for adding this improvement. Comment at: clang/test/Driver/debug-options.c:121 // RUN: %clang -### -c -g %s -target powerpc-

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 468914. qiongsiwu1 added a comment. Address the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ https://reviews.llvm.org/D136187 Files: clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:91 llvm::DebuggerKind getDefaultDebuggerTuning() const override { -return llvm::DebuggerKind::DBX; +return llvm::DebuggerKind::Default; } This sounds not right. Omitting `-

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 468626. qiongsiwu1 added a comment. Adding one more test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ https://reviews.llvm.org/D136187 Files: clang/lib/Driver/ToolChains/AIX.h clang/l

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: shchenz, lkail. qiongsiwu1 added projects: clang, debug-info. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. On AIX, the default tuning option is `dbx` so it is