shchenz added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/AIX.h:91
   llvm::DebuggerKind getDefaultDebuggerTuning() const override {
-    return llvm::DebuggerKind::DBX;
+    return llvm::DebuggerKind::Default;
   }
----------------
This sounds not right. Omitting `-debugger-tuning=dbx` does not mean we will 
change the default tuning  debugger on AIX, right? i.e. DBX is still the 
default debugger on AIX no matter in the clang fe or llvm be.

We should just be able to do some customization when we call 
`RenderDebugEnablingArgs` for AIX in 
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L4367-L4368


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136187/new/

https://reviews.llvm.org/D136187

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to