[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall accepted this revision. sammccall added a comment. Still LG! Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: nridge wro

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added a comment. (apologies, I'm also very tardy in getting back to this...) Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: --

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge updated this revision to Diff 470083. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://reviews.llvm.org/D133756 Files: clang-tools-e

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the long turnaround; have had some less-fun-than-code things to deal with :-) Thanks as always for patience... Main thing I'd still like is to split into two separate `functi

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge updated this revision to Diff 462702. nridge added a comment. Updated to use unique_function rather than inheritance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://reviews.llvm.org/D133756 Files: clang-tools-extra/clang

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: nridge wrote: > sammccall wrote: > > I have a couple

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: sammccall wrote: > I have a couple of concerns with t

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: I have a couple of concerns with this interface:

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151 clang::tooling::ArgumentsAdjuster( - clang::clangd::CommandMangler::detect())); + [Mangler = std::shared_ptr( + clang::clangd::CommandMangler:

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151 clang::tooling::ArgumentsAdjuster( - clang::clangd::CommandMangler::detect())); + [Mangler = std::shared_ptr( + clang::clangd::CommandMang

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added a comment. Herald added a subscriber: ormris. This is a refactoring in preparation for D133757 , please see that for motivation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://review

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Use it in