nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151
clang::tooling::ArgumentsAdjuster(
- clang::clangd::CommandMangler::detect()));
+ [Mangler = std::shared_ptr<clang::clangd::CommandMangler>(
+ clang::clangd::CommandMangler::detect().release())](
+ const std::vector<std::string> &Args, llvm::StringRef File) {
----------------
tom-anders wrote:
> Just wondering, why do you need to convert to a shared_ptr here? Couldn't the
> lambda just take ownership of the unique_ptr?
ArgumentsAdjuster is a typedef for std::function which needs to be copyable,
not move-only
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133756/new/
https://reviews.llvm.org/D133756
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
