[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3801899 , @asb wrote: > It looks like they're still missing in this updated version of the patch? I have no idea what's going wrong here. I had been very careful to make sure the patch contained the new test file, but

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGeda2af575fdf: [RISCV][MC] Add support for experimental Zawrs extension (authored by reames). Changed prior to commit: h

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

luismarques added a comment. Regarding the overkill of "RISCVInstrInfoZawrs.td", how about having a "RISCVInstrInfoExtra.td" (or "RISCVInstrInfoExt.td") as a grab bag for everything that doesn't merit its own .td file? I think this is fine regarding the versioning issue. Seems to only be missin

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb added a comment. It looks like they're still missing in this updated version of the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames updated this revision to Diff 461345. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/Support/RISCVISAInfo.cpp llvm/lib/Target/RISCV/RISCV.td

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3795603 , @asb wrote: > Everything that's in this patch looks good to me - it's just missing some > simple round-trip tests in the style of rv32zicboz-valid.s (and perhaps an > -invalid.s that shows a sensible error me

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed. Everything that's in this patch looks good to me - it's just missing some simple round-trip tests in the style of rv32zicboz-valid.s (and perhaps an -invalid.s that shows a sensible error

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames updated this revision to Diff 460447. reames added a comment. Add docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/Support/RISCVISAInfo.

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3792627 , @asb wrote: > I think the summary of our discussion on this was: > > - The versioning confusion is unfortunate - ideally there would be discussion > elsewhere at RVI on improving the situation (either ELF attr

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb added a comment. I think the summary of our discussion on this was: - The versioning confusion is unfortunate - ideally there would be discussion elsewhere at RVI on improving the situation (either ELF attributes to indicate extensions are experimental, or making that unnecessary via never

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3790420 , @asb wrote: > The change in set of instructions without changing the version number is > concerning - do you know anyone involved in that group? It would be good to > feedback the difficulties this can cause

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb added a comment. The change in set of instructions without changing the version number is concerning - do you know anyone involved in that group? It would be good to feedback the difficulties this can cause for us. It's also not clear if there might be changes again during ratification with

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, jrtc27 wrote: > This doesn't really belong here, but a separat

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, This doesn't really belong here, but a separate RISCVInstrInfo

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames created this revision. reames added reviewers: palmer-dabbelt, sunshaoce, craig.topper, kito-cheng, jrtc27, frasercrmck, asb, luismarques. Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, Pkm