reames added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, ---------------- jrtc27 wrote: > This doesn't really belong here, but a separate RISCVInstrInfoZawrs.td also > seems a little overkill... hmm I had the same thoughts. I'm happy to defer to reviewers' preference. ================ Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:95 bool HasStdExtZmmul = false; + bool HasStdExtZawrs = false; bool HasStdExtZtso = false; ---------------- jrtc27 wrote: > I would say keep these sorted but this seems to be a bit of a mess... I'm happy to sort in a separate change if you'd like. Preferably after this lands. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits