This revision was automatically updated to reflect the committed changes.
Closed by commit rL253388: [CUDA] Added a wrapper header for inclusion of stock
CUDA headers. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D13171?vs=38574&id=40435#toc
Repository:
rL LLVM
http:/
tra updated this revision to Diff 38574.
tra added a comment.
Added test cases for force-including of cuda_runtime.h
Tweaked inclusion of one header due to use of default arguments.
http://reviews.llvm.org/D13171
Files:
lib/Driver/ToolChains.cpp
lib/Headers/CMakeLists.txt
lib/Headers/cuda
echristo accepted this revision.
echristo added a comment.
In http://reviews.llvm.org/D13171#272441, @tra wrote:
> In http://reviews.llvm.org/D13171#272397, @echristo wrote:
>
> > I'm ignoring the content of the header, but this seems to be a not terrible
> > way to do things. I gather that cuda
tra added a comment.
In http://reviews.llvm.org/D13171#272397, @echristo wrote:
> I'm ignoring the content of the header, but this seems to be a not terrible
> way to do things. I gather that cuda_runtime.h is something that's typically
> included by the driver by nvidia and not the client?
C
echristo added a comment.
I'm ignoring the content of the header, but this seems to be a not terrible way
to do things. I gather that cuda_runtime.h is something that's typically
included by the driver by nvidia and not the client?
Also, tests?
-eric
http://reviews.llvm.org/D13171
___
tra updated this revision to Diff 37912.
tra added a comment.
Herald added a subscriber: klimek.
Changed header wrapping strategy. Previous version was attempting to
make CUDA headers work for host/device compilations separately. In the
end host and device compilations ended up with different view
tra updated this revision to Diff 36048.
tra added a comment.
Renamed wrapper to cuda_runtime.h
Similarly to nvcc, automatically add "-include cuda_runtime.h" to CC1
invocations unless -nocudainc is specified.
http://reviews.llvm.org/D13171
Files:
lib/Driver/ToolChains.cpp
lib/Headers/CMak
cuda_runtime.h may be a better choice. nvcc -includes it during both host
and device compilation and this wrapper file is intended to serve a similar
purpose and will probably end up being -included by cc1 in the end.
--Artem
On Mon, Sep 28, 2015 at 6:26 PM, Eric Christopher
wrote:
> echristo
echristo added a comment.
Why not just call it cuda.h and use #include next for it and then fix it up?
-eric
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
The (vague) idea was to make clear that the header is *not* part of cuda
distribution.
That said, the file could use a better name.
Do any of these sound better?
* fix_cuda_headers.h
* adapt_cuda_headers.h
* cuda_shim.h
--Artem
On Sat, Sep 26, 2015 at 12:20 PM, Eric Christopher
wrote:
> echri
echristo added a comment.
Bikeshed: it's part of the clang headers, do we really need "clang" in the
header name?
-eric
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
eliben accepted this revision.
eliben added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
tra updated this revision to Diff 35760.
tra added a comment.
Include cuda.h and #error if we see wrong CUDA_VERSION.
http://reviews.llvm.org/D13171
Files:
lib/Headers/CMakeLists.txt
lib/Headers/clang_cuda_support.h
Index: lib/Headers/clang_cuda_support.h
==
tra marked an inline comment as done.
tra added a comment.
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eliben added inline comments.
Comment at: lib/Headers/clang_cuda_support.h:53
@@ +52,3 @@
+// WARNING: Preprocessor hacks below are based on specific of
+// implementation of CUDA-7.0 headers and are expected to break with
+// any other version of CUDA headers.
If
tra updated this revision to Diff 35747.
tra added a comment.
Fixed typos and whitespace nits.
use #pragma push_macro for __CUDACC_RTC__, too.
http://reviews.llvm.org/D13171
Files:
lib/Headers/CMakeLists.txt
lib/Headers/clang_cuda_support.h
Index: lib/Headers/clang_cuda_support.h
=
tra created this revision.
tra added reviewers: echristo, eliben, jholewinski.
tra added a subscriber: cfe-commits.
Header files that come with CUDA are assuming split host/device compilation and
are not usable by clang out of the box.
With a bit of preprocessor magic it's possible to twist them
17 matches
Mail list logo
