tra added a comment.

In http://reviews.llvm.org/D13171#272397, @echristo wrote:

> I'm ignoring the content of the header, but this seems to be a not terrible 
> way to do things. I gather that cuda_runtime.h is something that's typically 
> included by the driver by nvidia and not the client?


Correct. cuda_runtime.h (and all it pulls in) is -include'd under the hood by 
nvcc.

> Also, tests?


I'll add a test to verify that "-include cuda_runtime.h" shows up on cc1 
command line where/when it's expected.

What would be a good way to test the wrapper itself within clang tree without 
real CUDA headers?

I've done fair amount of manual testing outside of clang source tree.

- manual comparison of preprocessed output from cuda_runtime.h between host and 
device passes.
- compiled 39 out of 46 thrust examples and verified that they produce output 
identical to nvcc-compiled binaries.


http://reviews.llvm.org/D13171



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to