[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis updated this revision to Diff 449463. ellis added a comment. Rename `omitprofile` => `skipprofile` since this seems slightly better to me. Of course I'm still open to more suggestions. Also, fix the `profile-function-groups.c` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

paulkirth added a comment. > I agree that `omitprofile` probably doesn't communicate the correct meaning > very well. I like `nodirectprofile` because it hopefully implies that > indirect profiles are allowed. I'm wondering if anyone else has suggestions. > > Is there any precedent for renamin

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis added a comment. In D130807#3688798 , @paulkirth wrote: > Do you expect the difference between `noprofile` and `omitprofile` to be > confusing to users? I can certainly see how users could be confused by what > the difference is between `noprofile

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

paulkirth added a comment. Do you expect the difference between `noprofile` and `omitprofile` to be confusing to users? I can certainly see how users could be confused by what the difference is between `noprofile` and `omitprofile` ... Since what you want to communicate is "never profile"(which

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis created this revision. Herald added subscribers: Enna1, wenlei, jdoerfert, hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: phosek, davidxl. ellis published this revision for review. Herald added projects: clang, LLVM. Herald added subs