This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG708084ec379e: [PowerPC] Support x86 compatible intrinsics on
AIX (authored by qiucf).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the enablement.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129461/new/
https://reviews.llvm.org/D129461
_
qiucf updated this revision to Diff 446335.
qiucf marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129461/new/
https://reviews.llvm.org/D129461
Files:
clang/lib/Driver/ToolChains/AIX.cpp
clang/lib/Headers/ppc_wrapp
shchenz added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232
+path::remove_filename(P);
+addSystemInclude(DriverArgs, CC1Args, P);
}
qiucf wrote:
> shchenz wrote:
> > Can we use `path::parent_path(P)` directly in `addSystemInclude
qiucf added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232
+path::remove_filename(P);
+addSystemInclude(DriverArgs, CC1Args, P);
}
shchenz wrote:
> Can we use `path::parent_path(P)` directly in `addSystemInclude()`?
> `remove_fil
shchenz added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232
+path::remove_filename(P);
+addSystemInclude(DriverArgs, CC1Args, P);
}
Can we use `path::parent_path(P)` directly in `addSystemInclude()`?
`remove_filename()` sounds l
qiucf added inline comments.
Comment at: clang/test/CodeGen/PowerPC/ppc-emmintrin.c:631
// CHECK: %[[ADDR:[0-9a-zA-Z_.]+]] = load double*, double**
%{{[0-9a-zA-Z_.]+}}, align 8
-// CHECK: %[[VAL:[0-9a-zA-Z_.]+]] = load double, double* %[[ADDR]], align 8
+// CHECK: %[[VAL:[0-9a-
qiucf updated this revision to Diff 444182.
qiucf added a comment.
Herald added a subscriber: ormris.
Merge conditions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129461/new/
https://reviews.llvm.org/D129461
Files:
clang/lib/Driver/ToolChains
qiucf updated this revision to Diff 444175.
qiucf marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129461/new/
https://reviews.llvm.org/D129461
Files:
clang/lib/Driver/ToolChains/AIX.cpp
clang/lib/Headers/ppc_wrapp
shchenz added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:226
+ // Add the PowerPC intrinsic headers (/include/ppc_wrappers)
+ if (!DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) &&
+ !DriverArgs.hasArg(options::OPT_nobuiltininc)) {
--
qiucf created this revision.
qiucf added reviewers: nemanjai, shchenz, hubert.reinterpretcast, PowerPC.
Herald added subscribers: jsji, steven.zhang, kbarton, krytarowski,
arichardson, emaste.
Herald added a project: All.
qiucf requested review of this revision.
Herald added subscribers: cfe-commi
11 matches
Mail list logo