[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3672666 , @vsapsai wrote: > In D126731#3670896 , @sammccall > wrote: > >> Hmm, I also don't know. >> The idea here is that we specifically depend only on the TokenKind enum f

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

vsapsai added a comment. In D126731#3670896 , @sammccall wrote: > Hmm, I also don't know. > The idea here is that we specifically depend only on the TokenKind enum from > TokenKinds.h (which doesn't need any generated headers), not on other headers > fr

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3670265 , @vsapsai wrote: > Looks like this breaks a modular build. I.e., > > My understanding is that the module 'Clang_Basic' needs .inc headers and this > module is pulled in by `#include "clang/Basic/TokenKinds.h

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

vsapsai added a comment. Looks like this breaks a modular build. I.e., cmake -GNinja ~/Projects/llvm/llvm-project/llvm \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" \ -DLLVM_ENABLE_ASSERTIONS=ON \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DLLVM_ENABLE_MODULES=ON ninja clangPse

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3609511 , @fmayer wrote: > FWIW this is not really NFC, I found this as the culprit in bisecting the > Android LLVM toolchain build, causing the following error: > > FAILED: tools/clang/tools/extra/pseudo/include/C

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

fmayer added a comment. FWIW this is not really NFC, I found this as the culprit in bisecting the Android LLVM toolchain build, causing the following error: FAILED: tools/clang/tools/extra/pseudo/include/CXXBNF.inc /usr/local/google/home/fmayer/llvm-toolchain/out/stage2/tools/clang/tools/extr

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc63ad8878de: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126731/new/

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:10 #include "clang-pseudo/Grammar.h" #include "clang/Basic/TokenKinds.h" #include "llvm/ADT/ArrayRef.h" hokein wrote: > Add a trailing comment `// for clang::tok::Tok

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice. > ninja clean; ninja pseudo-gen runs 169 actions only I think previous version was ~400 actions. Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:10 #inc

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. ClangBasic dependency el