hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Nice. > ninja clean; ninja pseudo-gen runs 169 actions only I think previous version was ~400 actions. ================ Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:10 #include "clang-pseudo/Grammar.h" #include "clang/Basic/TokenKinds.h" #include "llvm/ADT/ArrayRef.h" ---------------- Add a trailing comment `// for clang::tok::TokenKind`? Maybe even remove this include -- we have an include in the Grammar.h, though it makes this file less IWYU-friendly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126731/new/ https://reviews.llvm.org/D126731 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
