Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-28 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. I will look into it. Do you prefer to revert the patch this it is fixed? Repository: rL LLVM http://reviews.llvm.org/D12652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-28 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Looks like this patch is causing regressions: https://llvm.org/bugs/show_bug.cgi?id=24914 Repository: rL LLVM http://reviews.llvm.org/D12652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-11 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visited. + bool shouldInlineLa

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247426: [Static Analyzer] Lambda support. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12652?vs=34498&id=34555#toc Repository: rL LLVM http://reviews.llvm.org/D12652 Files

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-11 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visited. + bool shouldInlineLa

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-10 Thread Jordan Rose via cfe-commits
jordan_rose added a comment. A few comments coming late… Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visi

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-10 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Please, do turn on by default. LGTM http://reviews.llvm.org/D12652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-10 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. In http://reviews.llvm.org/D12652#243762, @zaks.anna wrote: > Have you tested this on a large codebase that uses lambdas? When do you think > we should turn this on by default? I checked llvm and clang and did not found any failure. There are no obvious limitations

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-10 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 34498. xazax.hun added a comment. - Updated to latest trunk - Added test for the defensive inline check heuristic case - Added test for diagnostic within a lambda body - Added test for path notes http://reviews.llvm.org/D12652 Files: include/clang/Stati

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-10 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Have you tested this on a large codebase that uses lambdas? When do you think we should turn this on by default? Please, add test cases that demonstrate what happens when an issue is reported within a lambda and to check if inlined defensive checks work. (As a follow

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-08 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 34285. xazax.hun added a comment. - Updated to newest trunk. - Moved the feature behind an option. - Fixed a crash when an operator() of a lambda is analyzed as a top level function, and a ThisExpr is referring to the this in the enclosing scope (this can

[PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-04 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: dcoughlin, zaks.anna, jordan_rose, ted. xazax.hun added a subscriber: cfe-commits. This patch adds lambda support for the static analyzer. All of my initial tests are passed. Before this patch each time a LambdaExpr was encountered a sin