xazax.hun added a comment.

In http://reviews.llvm.org/D12652#243762, @zaks.anna wrote:

> Have you tested this on a large codebase that uses lambdas? When do you think 
> we should turn this on by default?


I checked llvm and clang and did not found any failure. There are no obvious 
limitations or problems that I know of at the moment. I think this is a good 
candidate to turn on by default. At least some potential errors might be found 
earlier.

> Please, add test cases that demonstrate what happens when an issue is 
> reported within a lambda and to check if inlined defensive checks work.


I extended the tests with these cases.

> (As a follow up to this patch, we may need to teach LiveVariables.cpp and 
> UninitializedValues.cpp about lambdas. For example, to address issues like 
> this one: https://llvm.org/bugs/show_bug.cgi?id=22834)





http://reviews.llvm.org/D12652



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to