[PATCH] D125946: Handles failing driver tests of clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG168d4e2945a9: Handles failing driver tests of clang (authored by Purva-Chaudhari). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125946/new/ https://reviews.llvm.org/D125946 ___ cfe-commits mailing list

[PATCH] D125946: Handles failing driver tests of clang

Purva-Chaudhari updated this revision to Diff 444238. Purva-Chaudhari added a comment. modify tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125946/new/ https://reviews.llvm.org/D125946 Files: clang/lib/Interpreter/IncrementalParser.cpp clang/test/Interpreter/incremental-mode.

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify dblaikie wrote: > v.g.vassilev wrot

[PATCH] D125946: Handles failing driver tests of clang

dblaikie added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify v.g.vassilev wrote: > dblaikie wrote: >

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify dblaikie wrote: > dblaikie wrote: >

[PATCH] D125946: Handles failing driver tests of clang

dblaikie added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify dblaikie wrote: > v.g.vassilev wrote: >

[PATCH] D125946: Handles failing driver tests of clang

dblaikie added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify v.g.vassilev wrote: > @rsmith, would it

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added reviewers: rsmith, lhames, dblaikie, sgraenitz. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. @Purva-Chaudhari, this looks reasonable to me. I am adding more reviewers to discuss the way we refer other tests from `

[PATCH] D125946: Handles failing driver tests of clang

Purva-Chaudhari created this revision. Purva-Chaudhari added a reviewer: v.g.vassilev. Herald added a project: All. Purva-Chaudhari requested review of this revision. Added support for incremental mode 8 and 28 ie. `frontend::EmitBC:` and `frontend::PrintPreprocessedInput:` Added supporting clang