dblaikie added inline comments.

================
Comment at: clang/test/Interpreter/clangtests.cpp:1
+// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify
+// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify
----------------
v.g.vassilev wrote:
> @rsmith, would it be acceptable to have a test that refers other tests from 
> the repo in that manner?
Generally that's not done - and the inputs should be moved into an "Inputs" 
subdirectory and shared from there. Tests that are in different subdirectories 
- not sure if there's a good way to share those, maybe with an "Inputs" 
directory in a parent directory of both tests? We might not have precednt for 
that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125946/new/

https://reviews.llvm.org/D125946

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to