[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45643cfcc12e: [clang][dataflow] Centralize expression skipping logic (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua marked an inline comment as done. li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_c

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_cast_or_null(Env.getValue(RHS, SkipPast::Referen

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_cast_or_null(Env.getValue(RHS, SkipPast::Refe

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua updated this revision to Diff 427417. li.zhe.hua marked 3 inline comments as done. li.zhe.hua added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124965/new/ https://reviews.llvm.org/D124965 Files:

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:368 void Environment::setStorageLocation(const Expr &E, StorageLocation &Loc) { - assert(!isa

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua created this revision. li.zhe.hua added reviewers: sgatev, ymandel. Herald added subscribers: tschuett, steakhal. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to 62b2a47