Re: [PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

thank you, this is really appreciated. On Fri, May 20, 2022 at 12:32 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D123667#3524711 , > @aaron.ballman wrote: > > > In D123667#3524614

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman added a comment. In D123667#3524711 , @aaron.ballman wrote: > In D123667#3524614 , @tcanabrava > wrote: > >> This affects all released versions of llvm14, and potentially llvm13 too (I >> got a cr

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman added a comment. In D123667#3524614 , @tcanabrava wrote: > This affects all released versions of llvm14, and potentially llvm13 too (I > got a crash today on llvm13 hitting this exact code). > yet, this is not backported to llvm14 on the c

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tcanabrava added a comment. This affects all released versions of llvm14, and potentially llvm13 too (I got a crash today on llvm13 hitting this exact code). yet, this is not backported to llvm14 on the current 14.x github branch. Please backport so this is released on the next tarball. Reposi

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've commit on your behalf in 225b91e6cbba31ff1ce787a152a67977d08fdcab . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah added a comment. Yes please commit on my behalf. My details are Tom Eccles tom.ecc...@codethink.co.uk Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667 __

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a commenting nit. The Precommit CI test failures look unrelated to me as well. Do you need me to commit on your behalf? If so, what name and email address would you l

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah added a comment. I'm not able to reproduce the test failure in CI. It looks spurious to me because I have not changed anything related to openmp. The only change in behaviour after my patch should be to avoid a null pointer dereference. In tests which did not hit that null pointer derefer

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah updated this revision to Diff 422906. tblah added a comment. Added a unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667 Files: clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinte

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman edited reviewers, added: aaron.ballman; removed: lattner. aaron.ballman added a comment. This looks good in general, but can you add a test case for the scenario which previously crashed and a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah created this revision. tblah added a reviewer: rsmith. Herald added a project: All. tblah requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NamedDecl::getIdentifier can return a nullptr when DeclarationName::isIdentifier is false, whic