[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire updated this revision to Diff 425134. junaire added a comment. use std::move(). I'm not sure this will be better but hope it will make others happy :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D1234

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

dblaikie added a comment. Perhaps GlobalModuleIndex should create the cursor itself - it's being handed the buffer anyway? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D123436

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire added inline comments. Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr IndexBuffer, -llvm::BitstreamCursor Cursor) +llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(),

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

RKSimon added inline comments. Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr IndexBuffer, -llvm::BitstreamCursor Cursor) +llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(),

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire created this revision. junaire added reviewers: aaron.ballman, RKSimon, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. BitstreamCursors are heavy-w