Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-10-02 Thread Samuel Antao via cfe-commits
sfantao closed this revision. sfantao added a comment. Committed in r249154. Thanks! Samuel http://reviews.llvm.org/D12262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao updated the summary for this revision. sfantao updated this revision to Diff 34870. sfantao added a comment. Rebase with the last changes in http://reviews.llvm.org/D12871. http://reviews.llvm.org/D12262 Files: include/clang/Basic/OpenMPKinds.h include/clang/Sema/Sema.h lib/Basic/

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-09-02 Thread Alexey Bataev via cfe-commits
ABataev added a comment. LGTM http://reviews.llvm.org/D12262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-09-01 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:702 @@ +701,3 @@ + return true; +} + } Alexey, after rebasing this patch with the latest changes, I started having a regression related with how `DSAStack->hasDirective` works. In my und

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-09-01 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 33712. sfantao added a comment. Rebase on top of the last changes in http://reviews.llvm.org/D11361. http://reviews.llvm.org/D12262 Files: include/clang/Basic/OpenMPKinds.h include/clang/Sema/Sema.h lib/Basic/OpenMPKinds.cpp lib/Sema/SemaExpr.cpp

[PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-08-21 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, rjmccall, hfinkel. sfantao added a subscriber: cfe-commits. All global variables that are not enclosed in a declare target region must be captured in the target region as local variables do. Currently, there is no support for decla