[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

mgehre-amd abandoned this revision. mgehre-amd added a comment. Instead of linking to libbitint, I instead created a backend pass to transform div/rem instructions: https://reviews.llvm.org/D130076 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1222

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

mgehre-amd marked an inline comment as done. mgehre-amd added a comment. I split the introduction of -fexperimental-max-bitint-width into https://reviews.llvm.org/D127287 because there is still discussion about the bitint libraries in the backend PRs. Repository: rG LLVM Github Monorepo CHA

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:456 if (IncStdLib && IncDefLibs) { +addBitIntRuntime(HTC, CmdArgs, Args); + The runtime library order matters and roughly reflects a topological order. For instances, -lc is

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

aaron.ballman added a comment. This looks generally correct to me, but precommit CI is currently failing with a relevant issue (what a nice change of pace): Failed Tests (1): Clang :: Driver/linux-ld.c Comment at: clang/include/clang/Basic/TargetInfo.h:603 +if (Max

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:315 #define BENIGN_ENUM_LANGOPT(Name, Type, Bits, Default, Description) -#define BENIGN_VALUE_LANGOPT(Name, Type, Bits, Default, Description) +#define BENIGN_VALUE_LANGOPT(Name, Bits, Default, De

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd updated this revision to Diff 418861. mgehre-amd added a comment. Herald added a subscriber: dexonsmith. - Remove diagnostics for float-to-bitint - Remove lexer changes (will be another PR) - Add -fexperimental-max-bitint-width=N Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; mgehre-amd wrote: > aaron.ball

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd marked 2 inline comments as done. mgehre-amd added inline comments. Herald added a subscriber: MaskRay. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more tha

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; mgehre-amd wrote: > aaron.ball

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd marked 3 inline comments as done. mgehre-amd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; -

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

erichkeane added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1232 + if (llvm::isPowerOf2_32(radix)) { +unsigned BitsPerDigit = llvm::Log2(radix); mgehre-amd wrote: > erichkeane wrote: > > Can you explain what is going on here? This isn't

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; mgehre-amd wrote: > erichkeane

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd marked an inline comment as done. mgehre-amd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; -

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; Can you explain the issue here?

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd created this revision. mgehre-amd added reviewers: aaron.ballman, erichkeane. Herald added subscribers: luke957, s.egerton, mstorsjo, simoncook, fedor.sergeev, dschuff. Herald added a project: All. mgehre-amd requested review of this revision. Herald added subscribers: pcwang-thead, ahe