aaron.ballman added a comment. This looks generally correct to me, but precommit CI is currently failing with a relevant issue (what a nice change of pace):
Failed Tests (1): Clang :: Driver/linux-ld.c ================ Comment at: clang/include/clang/Basic/TargetInfo.h:603 + if (MaxBitIntWidth) + return std::min<unsigned>(MaxBitIntWidth, + llvm::IntegerType::MAX_INT_BITS); ---------------- So we get the return type correct? (I doubt this matters.) ================ Comment at: clang/lib/Serialization/ASTReader.cpp:315 #define BENIGN_ENUM_LANGOPT(Name, Type, Bits, Default, Description) -#define BENIGN_VALUE_LANGOPT(Name, Type, Bits, Default, Description) +#define BENIGN_VALUE_LANGOPT(Name, Bits, Default, Description) #include "clang/Basic/LangOptions.def" ---------------- mgehre-amd wrote: > This macro was taking the wrong number of arguments, but nobody noticed > because there was no `BENIGN_VALUE_LANGOPT` before. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122234/new/ https://reviews.llvm.org/D122234 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
