[PATCH] D120149: [clang][dataflow] Add support for global storage values

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ea103de140b: [clang][dataflow] Add support for global storage values (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https:

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev updated this revision to Diff 410580. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https://reviews.llvm.org/D120149 Files: clang/include/clang/Analysis/FlowSensitive/Datafl

[PATCH] D120149: [clang][dataflow] Add support for global storage values

xazax.hun added a comment. In D120149#056 , @sgatev wrote: > I think we should provide such functionality and it probably should also > apply to some of the pointer and reference values. Not sure what the default > should be, but having the ability

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev updated this revision to Diff 410041. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https://reviews.llvm.org/D120149 Files: clang/li

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev marked 2 inline comments as done. sgatev added a comment. I think we should provide such functionality and it probably should also apply to some of the pointer and reference values. Not sure what the default should be, but having the ability to choose the level of soundness for certain a

[PATCH] D120149: [clang][dataflow] Add support for global storage values

xazax.hun added a comment. Shouldn't there be a functionality to invalidate all the globals at every function call by default? Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:141 +// Global vars are already initialized in `Environment`. +if (D.hasGlobalStorag

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:80 + +/// Initializes global storage values in sub-expressions of `S`. +static void initGlobalVars(const Stmt &S, Environment &Env) { --

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev updated this revision to Diff 410014. sgatev marked 3 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https://reviews.llvm.org/D120149 Files: clang/li

[PATCH] D120149: [clang][dataflow] Add support for global storage values

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:74-77 + auto *V = dyn_cast(&D); + if (V == nullptr) +return; + initGlobalVar(*V, Env); -

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A